Skip to content

Correlator Layer 1 updates for Multiboard tests #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
epalencia merged 8 commits into from
Sep 20, 2023
Merged

Correlator Layer 1 updates for Multiboard tests #1157

epalencia merged 8 commits into from
Sep 20, 2023

Conversation

@gpetruc
Copy link

@gpetruc gpetruc commented Aug 22, 2023 •
edited
Loading

This PR updates the CMSSW Correlator Layer 1 code for the use in multi-board tests:

  • the forward hgcal region is now emulated accurately (physics performance should be unchanged since occupancies are well below the threshold at which truncations happen)
  • emulation of the correlator at tmux18 is now possible in CMSSW
  • the correlator pattern file writers are updated to run on the newer samples, to use a cabling map that reflects the current firmware, and to support also the tmux18 option

CMSSW master PR: cms-sw#42643

@gpetruc gpetruc mentioned this pull request Aug 23, 2023
Merged
@aloeliger aloeliger added Phase-2 Pertains to phase-2 development Emulator Development Emulator development PR labels Aug 29, 2023
@epalencia
Copy link

epalencia commented Sep 18, 2023

Hi @gpetruc, this PR is missing the latest commits in cms-sw#42643, no?

@gpetruc
Copy link
Author

gpetruc commented Sep 19, 2023

yes, i'll push them later tonight or tomorrow

Giovanni

@gpetruc
Copy link
Author

gpetruc commented Sep 19, 2023

Done now

@triggerDoctor
Copy link

triggerDoctor commented Sep 20, 2023

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

triggerDoctor commented Sep 20, 2023

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

triggerDoctor commented Sep 20, 2023

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

  • L1Trigger/L1CaloTrigger/plugins/L1EGammaCrystalsEmulatorProducer.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@epalencia epalencia merged commit 7880988 into cms-l1t-offline:phase2-l1t-integration-1252patch1 Sep 20, 2023
@epalencia
Copy link

epalencia commented Sep 20, 2023

Tagged as l1t-phase2-v77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Emulator Development Emulator development PR Phase-2 Pertains to phase-2 development

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gpetruc @epalencia @triggerDoctor @aloeliger